-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pytest_plugin with fixtures to test auth in core and extensions #956
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
Codecov Report
@@ Coverage Diff @@
## main #956 +/- ##
==========================================
+ Coverage 72.07% 72.24% +0.16%
==========================================
Files 64 64
Lines 8031 8098 +67
Branches 1340 1353 +13
==========================================
+ Hits 5788 5850 +62
- Misses 1837 1838 +1
- Partials 406 410 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @akshaychitneni!
jupyter_server/pytest_plugin.py
Outdated
if fetch is jp_ws_fetch: | ||
r.close() | ||
|
||
print(code, url, fetch_kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be removed? 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @akshaychitneni! Just a minor comment inline. Otherwise this looks good!
08663bb
to
3550405
Compare
3550405
to
3132a62
Compare
Thanks @Zsailer. Updated. |
Fixes #773