Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move nbformat and nbformat_minor to meta YMap #21

Merged
merged 3 commits into from
May 12, 2022
Merged

Move nbformat and nbformat_minor to meta YMap #21

merged 3 commits into from
May 12, 2022

Conversation

davidbrochart
Copy link
Collaborator

@davidbrochart davidbrochart commented May 12, 2022

Tests won't pass because @jupyterlab/shared-models has to be released with the equivalent changes.

cc @hbcarlos

@hbcarlos
Copy link
Contributor

Also, In my opinion, we should change the names of the attributes to match the nbformat specification.

There is only one attribute to change, the nbformatMinor to nbformat_minor

self._ystate.set(t, "nbformatMinor", nb["nbformat_minor"])

@davidbrochart
Copy link
Collaborator Author

Good point, fixed in b9c53fa.

@hbcarlos
Copy link
Contributor

Thanks! LGTM.

@davidbrochart
Copy link
Collaborator Author

The CI failure is expected because we need to make the equivalent changes in @jupyterlab/shared-models and release them.

@davidbrochart davidbrochart merged commit 3662d97 into main May 12, 2022
@davidbrochart davidbrochart deleted the meta branch May 12, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants