Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Binder and launch jupyverse directly #76

Merged
merged 3 commits into from
Sep 24, 2021

Conversation

davidbrochart
Copy link
Collaborator

Closes #73

@davidbrochart davidbrochart force-pushed the improve_binder branch 3 times, most recently from 098ca32 to c118c2c Compare September 24, 2021 09:34
@davidbrochart davidbrochart marked this pull request as draft September 24, 2021 09:35
@davidbrochart davidbrochart force-pushed the improve_binder branch 8 times, most recently from 8dd35d0 to 11c3819 Compare September 24, 2021 11:27
@davidbrochart davidbrochart marked this pull request as ready for review September 24, 2021 11:27
@davidbrochart
Copy link
Collaborator Author

@jtpio @fcollonval you can try it here: https://mybinder.org/v2/gh/davidbrochart/jupyverse/improve_binder
IIUC it doesn't launch jupyverse directly, you need to click on jupyverse in the launcher?

@jtpio
Copy link
Member

jtpio commented Sep 24, 2021

Probably setting ?urlpath=jupyverse in the Binder URL will handle the redirect?

@davidbrochart
Copy link
Collaborator Author

Indeed, thanks.
Any way to not have the ?token=l8XZNQDWR-KQiuMuwQtemQ query parameter?

@fcollonval
Copy link
Member

Probably setting ?urlpath=jupyverse in the Binder URL will handle the redirect?

I thought that too but it does not work...
May be related I see that in the server log:

if have_lab:
    # if recent-enough lab is available, make it the default UI
    sys.argv.insert(1, "--NotebookApp.default_url=/lab/")

@davidbrochart
Copy link
Collaborator Author

I thought that too but it does not work...

This works: https://mybinder.org/v2/gh/davidbrochart/jupyverse/improve_binder?urlpath=jupyverse
The problem is that jupyverse expects a UUID for the token, but here we launch it with noauth anyway so there should not be any token query parameter.

@fcollonval
Copy link
Member

This works: https://mybinder.org/v2/gh/davidbrochart/jupyverse/improve_binder?urlpath=jupyverse

I get the following answer: {"detail":[{"loc":["query","token"],"msg":"value is not a valid uuid","type":"type_error.uuid"}]}

Not the application

@davidbrochart
Copy link
Collaborator Author

davidbrochart commented Sep 24, 2021

Yes, jupyverse expects a UUID (when launched with --authenticator.mode=token), that's why we shouldn't pass a token query parameter (the one from Jupyter is not a UUID).

@davidbrochart
Copy link
Collaborator Author

davidbrochart commented Sep 24, 2021

I guess we can allow the token to be any string.
This works now, the only thing is that it only launches the JupyterLab frontend (compared to before where we had the choice to choose RetroLab). Maybe we could add another server in jupyter_notebook_config.py for RetroLab?

@davidbrochart davidbrochart force-pushed the improve_binder branch 3 times, most recently from f7ea6da to e5e7252 Compare September 24, 2021 12:47
@davidbrochart
Copy link
Collaborator Author

Someone wants to squash and merge?

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio
Copy link
Member

jtpio commented Sep 24, 2021

Looks good on Binder:

image

@jtpio jtpio merged commit bffd6c7 into jupyter-server:main Sep 24, 2021
@davidbrochart davidbrochart deleted the improve_binder branch September 24, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start jupyverse automatically on Binder
3 participants