Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new repo for File ID server extension #33

Closed
9 of 28 tasks
dlqqq opened this issue Aug 22, 2022 · 11 comments
Closed
9 of 28 tasks

new repo for File ID server extension #33

dlqqq opened this issue Aug 22, 2022 · 11 comments
Labels
vote Voted on by the Jupyter Server Council

Comments

@dlqqq
Copy link

dlqqq commented Aug 22, 2022

cc @Zsailer

I would like to migrate the work done in jupyter-server/jupyter_server#921 into a separate server extension. This gives us much more flexibility to iterate on the File ID service without having to make changes against Jupyter Server core. To do this, we would need a separate repo to store the File ID server extension.

Could you do this for us? I would also like to have write access such that I can make necessary changes early-on and be allowed to merge PRs.

Votes

@welcome
Copy link

welcome bot commented Aug 22, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@Zsailer Zsailer added the vote Voted on by the Jupyter Server Council label Aug 25, 2022
@afshin
Copy link
Contributor

afshin commented Aug 25, 2022

cc: @jupyter-server/jupyter-server-council

@dlqqq
Copy link
Author

dlqqq commented Aug 29, 2022

Because this was brought up in the server meeting last Thursday 9 AM PT (8/25/2022), let's close the vote this Thursday 9 AM PT (9/1/2022), and take action accordingly by Friday.

@Zsailer
Copy link
Member

Zsailer commented Aug 29, 2022

I've updated the top comment to reflect voting state.

@ellisonbg
Copy link

I vote yes, but don't have repo permissions to vote.

@blink1073
Copy link
Contributor

@ellisonbg you should have an invitation email

@ellisonbg
Copy link

ellisonbg commented Aug 30, 2022 via email

@Zsailer
Copy link
Member

Zsailer commented Sep 1, 2022

Ok! We've reached quorum and the consensus is "yes"!

Let's proceed to create the repo. @dlqqq what would you like to call the repo? Once I get confirmation there, I'll create the new repo and add you as collaborator.

@dlqqq
Copy link
Author

dlqqq commented Sep 1, 2022

@Zsailer Thank you! I was thinking it would be created under the jupyter-server org with the repo named as jupyter_server_fileid. This seems to match the convention of other server extensions (using underscores and being prefixed with jupyter_server).

@dlqqq
Copy link
Author

dlqqq commented Sep 1, 2022

Sorry I wasn't able to attend the server meeting earlier; was at a dental appointment.

@Zsailer
Copy link
Member

Zsailer commented Sep 1, 2022

@dlqqq done 🚀 😎 : https://github.com/jupyter-server/jupyter_server_fileid

@Zsailer Zsailer closed this as completed Sep 1, 2022
@Zsailer Zsailer mentioned this issue Nov 8, 2023
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vote Voted on by the Jupyter Server Council
Projects
None yet
Development

No branches or pull requests

5 participants