Fix calling .remove() when in an output widget.

jupyter-widgets · Apr 13, 2017 · 00b16dc · 00b16dc
1 parent 117a155
commit 00b16dc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/widgetsnbextension/src/extension.js b/widgetsnbextension/src/extension.js
@@ -70,6 +70,7 @@ function register_events(Jupyter, events, outputarea) {
     events.on('delete.Cell', removeView);
     events.on('execute.CodeCell', removeView);
     events.on('clear_output.CodeCell', removeView);
+    events.on('clear_output.OutputArea', removeView);
 
     /**
      * Render data to the output area.

diff --git a/widgetsnbextension/src/widget_output.js b/widgetsnbextension/src/widget_output.js
@@ -66,7 +66,7 @@ var OutputView = widgets.DOMWidgetView.extend({
 
     render: function(){
         var that = this;
-        var renderOutput = function(outputArea) {
+        var renderOutput = function(outputArea, events) {
             that.output_area = new outputArea.OutputArea({
                 selector: that.el,
                 // use default values for the output area config
@@ -79,15 +79,16 @@ var OutputView = widgets.DOMWidgetView.extend({
             }, that);
             that.listenTo(that.model, 'clear_output', function(msg) {
                 that.output_area.handle_clear_output(msg);
-            })
+                events.trigger('clear_output.OutputArea', {cell: {output_area: that.output_area}})
+            });
 
             // Render initial contents from that.model._outputs
             that.model._outputs.forEach(function(msg) {
                 that.output_area.handle_output(msg);
             }, that)
         }
 
-        requirejs(["notebook/js/outputarea"], renderOutput)
+        requirejs(["notebook/js/outputarea", "base/js/events"], renderOutput)
     },
 });