Skip to content

Commit

Permalink
Add explanatory comment to classic widget manager
Browse files Browse the repository at this point in the history
  • Loading branch information
jasongrout committed Jan 30, 2020
1 parent a507eae commit e744957
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions widgetsnbextension/src/manager.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ export class WidgetManager extends baseManager.ManagerBase {
// for the responses (2).
return Promise.all(comm_promises)
.then(function(comms) {
// We must do this in batches to make sure we do not
// exceed the ZMQ high water mark limiting messages from the kernel. See
// https://github.com/voila-dashboards/voila/issues/534 for more details.
return baseManager.mapBatch(comms, 100, function(comm) {
var update_promise = new Promise(function(resolve, reject) {
comm.on_msg(function(msg) {
Expand Down

0 comments on commit e744957

Please sign in to comment.