Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLManager uses hardcoded entrypoint (dist/<name>.js) for extensions #3898

Open
timkpaine opened this issue Apr 5, 2024 · 0 comments
Open

Comments

@timkpaine
Copy link
Contributor

timkpaine commented Apr 5, 2024

Description

HTMLManager is hardcoded to pull from dist/<package name>

We should inspect the main attribute of the package.json if possible to identify the entrypoint.

Reproduce

use e.g. perspective which emits to dist/esm/

This likely won't work anyway due to use of esm, but just an example.

Expected behavior

Use the extension's preferred entry point, at the bare minimum main but ideally per-cdn.

Context

#2381
voila-dashboards/voila#1128
voila-dashboards/voila#1154
bqplot/bqplot#1495

timkpaine added a commit to timkpaine/ipywidgets that referenced this issue Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant