Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export LabWidgetManager and KernelWidgetManager #3166

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 19, 2021

This is a proposal to export the LabWidgetManager and KernelWidgetManager from the @jupyter-widgets/jupyterlab-manager package.

This will let third-party packages and extensions import these managers with:

import { KernelWidgetManager, LabWidgetManager } from '@jupyter-widgets/jupyterlab-manager';

Instead of:

import { KernelWidgetManager, LabWidgetManager } from '@jupyter-widgets/jupyterlab-manager/lib/manager';

This would be useful to other applications that would like to reuse the widget managers as is, or extend their functionalities by subclassing them. See voila-dashboards/voila#846 for a work-in-progress example.

Opening this PR as a way to discuss whether or not we should do this, since exposing new classes increases the API surface.

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch jtpio/ipywidgets/expose-widget-managers

@jtpio jtpio added this to the 8.0 milestone Mar 19, 2021
@jtpio
Copy link
Member Author

jtpio commented Mar 19, 2021

Adding to the 8.0 milestone for the API surface considerations.

@jtpio jtpio changed the title Expose LabWidgetManager and KernelWidgetManager Export LabWidgetManager and KernelWidgetManager Mar 19, 2021
@vidartf
Copy link
Member

vidartf commented Mar 25, 2021

I'm 👍 on this.

@jasongrout jasongrout merged commit eea5071 into jupyter-widgets:master Mar 25, 2021
@jtpio jtpio deleted the expose-widget-managers branch March 25, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants