Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the JupyterLab extension into plugins that provide the widget manager and register widgets #3442

Merged
merged 3 commits into from
Jul 22, 2022

Conversation

jasongrout-db
Copy link

This paves the way to having separate extensions that load multiple versions of core widgets, so that ipywidgets 7.x and 8.x can be supported simultaneously, for example.

See also conversation at #3429

…anager and register widgets.

This paves the way to having separate extensions that load multiple versions of core widgets, so that ipywidgets 7.x and 8.x can be supported simultaneously, for example.
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch jasongrout/ipywidgets/plugins

@jasongrout jasongrout added this to the 8.0 milestone May 10, 2022
@vidartf
Copy link
Member

vidartf commented Jul 12, 2022

@jasongrout What work remains here? Is this something that we should block 8.0 for?

@jasongrout jasongrout marked this pull request as ready for review July 16, 2022 06:38
@jasongrout
Copy link
Member

@jasongrout What work remains here? Is this something that we should block 8.0 for?

I fixed the remaning errors, and I think this is ready for review.

@jasongrout jasongrout requested a review from vidartf July 19, 2022 16:51
Copy link
Member

@vidartf vidartf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes here are fine. Thinking about the stated goal of supporting 7.x and 8.x side-by-side, I do have some concerns w.r.t to most third party extensions declaring base and controls (if depending on controls) as singletons in their package.json's jupyterlab section.

@jasongrout
Copy link
Member

I do have some concerns w.r.t to most third party extensions declaring base and controls (if depending on controls) as singletons in their package.json's jupyterlab section.

They should be doing that anyway.

@vidartf vidartf merged commit e80edd7 into jupyter-widgets:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants