Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extract_filename function #409

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix extract_filename function #409

wants to merge 2 commits into from

Conversation

anutosh491
Copy link
Contributor

@anutosh491 anutosh491 commented Oct 4, 2024 •
edited
Loading

If the extract_filename function is going to be editing argv, then it also needs to make a corresponding change to argc.

I thought this would work right out off the bat when I was using it for xeus-cpp but it ends up giving me errors (shown in this PR compiler-research/xeus-cpp#153)

@anutosh491 anutosh491 changed the title Extract filename Fix extract_filename function Oct 4, 2024
JohanMabille
JohanMabille reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@JohanMabille JohanMabille left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the extract_filename function deserves some documentation in the header file, otherwise it looks like a side effect bug.

Also this fix is backward incompatible, so when it gets it, we're on the way for xeus 6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anutosh491 @JohanMabille