Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vidar as new Jupyter Server SSC Representative #759

Merged
merged 2 commits into from
May 15, 2024

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented May 10, 2024

@JohanMabille
Copy link
Member

JohanMabille commented May 13, 2024

LGTM, let's @vidartf have a look and check everything is correct on his side before merging.

about.html Outdated Show resolved Hide resolved
Copy link
Contributor

@vidartf vidartf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor naming tweak 👍

Co-authored-by: Vidar Tonaas Fauske <[email protected]>
Copy link
Member

@jasongrout jasongrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@jasongrout
Copy link
Member

Looks like the check links test is failing for unrelated reasons.

@jasongrout jasongrout merged commit 8d83327 into jupyter:main May 15, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants