Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel Providers should be deprecated in jupyter client #495

Closed
kevin-bates opened this issue Nov 8, 2019 · 2 comments
Closed

Kernel Providers should be deprecated in jupyter client #495

kevin-bates opened this issue Nov 8, 2019 · 2 comments

Comments

@kevin-bates
Copy link
Member

While looking into how nb_conda_kernels work I realized that jupyter_client has discovery.py - which exposes the KernelProvider work that is really taking place in @takluyver's repos: takluyver/jupyter_kernel_mgmt and takluyver/jupyter_protocol. In addition, I see that there are folks using the kernel provider framework in jupyter_client - which includes the make_manager() method - which no longer exists in the definitive framework.

The plan is that the jupyter_server will leverage jupyter_kernel_mgmt's KernelProvider framework. The framework will support asyncio and parameterized launches (aka parameterized kernels), etc. There are no plans to use this framework from within jupyter_client. Applications using jupyter_client will need to switch to using juptyer_kernel_mgmt/juptyer_protocol to take advantage of KernelProviders, async management and parameterized launches. This does not preclude building similar support into jupyter_client's kernel management - although those efforts should not include the KernelProvider architecture.

As a result, we should deprecate jupyter_client's discovery.py, and the classes that it implements, with proper messaging to use jupyter_kernel_mgmt instead. Fortunately, discovery.py is not currently included in any releases, nor should it be.

kevin-bates added a commit to kevin-bates/jupyter_client that referenced this issue Nov 8, 2019
@SylvainCorlay
Copy link
Member

Hi @kevin-bates I think that we can close the issue as we are going to point master at the current head of 5.x.

@kevin-bates
Copy link
Member Author

I agree - thanks @SylvainCorlay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants