reimplement uuid4 in session #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other than the failing type-assertion in the 2.7 tests, LGTM! |
avoids call-time imports in stdlib uuid, which can cause threading issues with Python import locks. We don't ever need actual UUIDs, we just want random strings, so we could skip UUID's `-` formatting.
minrk
force-pushed
the
uuid4-no-import
branch
from
c0d7d63
to
4a38bdc
Compare
takluyver
reviewed
Sep 26, 2016
| """ | ||
| buf = os.urandom(16) | ||
| return u'-'.join(b2a_hex(x).decode('ascii') for x in ( | ||
| buf[:4], buf[4:6], buf[6:8], buf[8:10], buf[10:] |
There was a problem hiding this comment.
Even a random UUID is not just random bytes; there are a couple of type fields in there to indicate what kind of UUID it is.
https://en.wikipedia.org/wiki/Universally_unique_identifier#Version_4_.28random.29
As you say, we don't really need UUID, just a string that's unique in context. So if we're just going to generate random bytes, let's not call it a uuid or format it like a uuid.
There was a problem hiding this comment.
Good call. Called it new_id, and skipped the uuid-specific layout.
instead of uuid, since it doesn’t implement the uuid spec and skip uuid layout
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoids call-time imports in stdlib uuid, which can cause threading issues with Python import locks.
We don't ever need actual UUIDs, we just want random strings, so we could skip UUID's
-formatting.closes ipython/ipykernel#193
cc @rkern