Apply the traitlets observe and default patterns #415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecated) method naming _xxx_default and _xxx_changed
|
The build errors don't seem to be related to the changes I proposed. Should I have made the changes on the master branch? |
|
Sorry for the delay.
Yes, all pull requests should be made against master. Can you close and reopen a PR against master? I believe that has fixed the testing issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The traitlet pattern of naming methods _xxx_default and _xxx_changed is deprecated in favor of using the observe and default patters as documented here. This pr closes #386.