Exposes control channel in public API #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 12, 2019
rgbkrk
approved these changes
Jun 26, 2019
rgbkrk
reviewed
Jun 26, 2019
| @@ -14,6 +14,7 @@ __pycache__ | |||
| .coverage | |||
| .cache | |||
| absolute.json | |||
| *.swp | |||
There was a problem hiding this comment.
This shouldn't have been added as part of this PR, but it's fine for now. I recommend adding vim swap files to your global gitignore so this doesn't come up for you in future repositories.
There was a problem hiding this comment.
Thanks for pointing this out, to be honest I wasn't aware of this feature! I can make a PR to revert this change if you want.
There was a problem hiding this comment.
I think it's ok for the moment as it won't hurt anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the control channel in the public API, as required in #446. The
KernelClienthas not been updated to connect to the Control socket, it might be interesting to do it later.EDIT: additional changes might be required in
KernelManagerto avoid having another socket trying to connect on the Control channel, but this is not clear to me for now.