Reconcile connection information #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@meeseeksdev please backport to 7.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter_client
that referenced
this pull request
Nov 15, 2022
blink1073
pushed a commit
that referenced
this pull request
Nov 15, 2022
Co-authored-by: Kevin Bates <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the side discussion between myself and @blink1073 on PR #863 that was reworking #861, this PR checks that the existing connection file (should one exist) matches the connection information returned from the provisioner and prevents overwriting the connection file in such cases (to avoid the race condition addressed via #861).
These changes also ensure that once the connection file is written (if it didn't already exist) the connection information stored in attributes of
KernelManager(via theConnectionFileMixin) also matches that returned from the provisioner (which is considered the truth).