Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Proper typing and cast #906

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Dec 23, 2022

Cast has minimal if no runtime cost, and is slightly more precise that just ignoring types

Cast has minimal if no runtime cost, and is slightly more precise that
just ignoring types
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 1205e6c into jupyter:main Dec 23, 2022
@Carreau
Copy link
Member Author

Carreau commented Dec 23, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants