Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress any exception in _do_i_own shortcut #335

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Suppress any exception in _do_i_own shortcut #335

merged 1 commit into from
Jan 23, 2023

Conversation

minrk
Copy link
Member

@minrk minrk commented Jan 23, 2023

any error means it didn't work and we should move on

closes #334

@minrk
suppress any exception in _do_i_own shortcut
7cfd901 
any error means it didn't work and we should move on
@minrk minrk added the bug label Jan 23, 2023
@minrk minrk mentioned this pull request Jan 23, 2023
Closed
@blink1073 blink1073 changed the title suppress any exception in _do_i_own shortcut Suppress any exception in _do_i_own shortcut Jan 23, 2023
blink1073
blink1073 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit c268e91 into jupyter:main Jan 23, 2023
@minrk minrk deleted the safer-owner-check branch January 24, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uncaught error in directory ownership check
2 participants
@minrk @blink1073