Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow NBClassic to work with NB7 and ServerApp.base_url #165

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Allow NBClassic to work with NB7 and ServerApp.base_url #165

merged 2 commits into from
Oct 18, 2022

Commits on Oct 17, 2022

  1. Allow NBClassic to work if ServerApp.base_url is set and Notebook 7 i… 

    …s installed

Also resolves an issue where New->New Notebook did not respect the "/nbclassic/" in the url if it was set
Personally not a fan of the var still being called base_url_prefix but wans't willing to make that big of a change
Closes jupyter#164
    @mcrutch
    mcrutch committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    2ec4d64 View commit details
    Browse the repository at this point in the history

  2. Change name of url prefix to be more appropriate 

    Rename base_url_prefix to nbclassic_path
rename baseUrlPrefix to nbclassicPath
rename url_prefix_notebook() to nbclassic_path()
    @mcrutch
    mcrutch committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    c056d1a View commit details
    Browse the repository at this point in the history