Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/nbclassic base url #168

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Conversation

mcrutch
Copy link
Contributor

@mcrutch mcrutch commented Oct 19, 2022

This will ensure that the "Dashboard" link at the top left of Notebookv6/NBClassic always points back to the tree view no matter how jupyter was launched.
Closes #167

…book

Notebook v6 still has the same problem if jupyter is started with `server` or `lab`
Makes dashboard link point to /tree
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jupyter logo "dashboard" link goes to default app, breaking out of classic
2 participants