Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore some traits in shim layer #38

Merged
merged 2 commits into from
Jan 8, 2021
Merged

Ignore some traits in shim layer #38

merged 2 commits into from
Jan 8, 2021

Conversation

afshin
Copy link
Member

@afshin afshin commented Jan 7, 2021

Adds a list of traits that should be ignored by nbclassic's shim layer.

  • open_browser is now a trait of jupyter_server's ServerApp and ExtensionApp. These traits must have the same name for backward-compatibility.
  • log_level and log_format exist in ServerApp, ExtensionApp, and NotebookApp, and users need to be able to configure each one separately.

This PR also changes the name trait of nbclassic's NotebookApp to "notebook". This enables nbclassic to find the jupyter_notebook_config.py

nbclassic/shim.py Outdated Show resolved Hide resolved
Co-authored-by: Kevin Bates <[email protected]>
@Zsailer Zsailer merged commit 5b757b8 into jupyter:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants