Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default_url trait to NotebookApp #42

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Add default_url trait to NotebookApp #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions nbclassic/notebookapp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@ class NotebookApp(
flags = flags
extension_url = "/tree"

default_url = Unicode("/tree").tag(config=True)

# Override the default open_Browser trait in ExtensionApp,
# setting it to True.
open_browser = Bool(
Expand Down
2 changes: 1 addition & 1 deletion nbclassic/shim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@

# A tuple of traits that shouldn't be shimmed or throw any
# warnings of any kind.
IGNORED_TRAITS = ("open_browser", "log_level", "log_format")
IGNORED_TRAITS = ("open_browser", "log_level", "log_format", "default_url")


class NBClassicConfigShimMixin:
Expand Down