Monkeypatch IPythonHandler to find nbclassic's jinja templates #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… routes to match classic notebook
Zsailer
changed the title
|
Nice, thanks for the fix! |
aaraney
pushed a commit
to aaraney/nbfetch
that referenced
this pull request
Jan 14, 2022
…pyterhub#77 to avoid clashing with jupyter_server. see jupyter/nbclassic#77 for history
aaraney
pushed a commit
to hydroshare/nbfetch
that referenced
this pull request
Jan 14, 2022
…pyterhub#77 to avoid clashing with jupyter_server. see jupyter/nbclassic#77 for history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes jupyterlab/jupyterlab#11345 and jupyterlab/jupyterlab#11350.
Because notebook (or nbclassic's) HTML templates were merged with jupyter-server's in #63 and the templates share the same name, the jupyter_server templates were getting clobbered.
This properly namespaces them by monkeypatching where
IPythonHandlerspulls it's templates.This also fixes an issue with a missing
base_urlin some of nbclassic's handlers.