Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make extra_arguments configurable #66

Merged
merged 1 commit into from
May 21, 2020
Merged

make extra_arguments configurable #66

merged 1 commit into from
May 21, 2020

Conversation

tdpetrou
Copy link
Contributor

This is in regards to this issue I created on nbconvert.

choldgraf
choldgraf approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the implications of this are (traitlets is still an enigma to me) but seems reasonable to me!

MSeal
MSeal approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MSeal MSeal merged commit 10956c6 into jupyter:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSeal MSeal MSeal approved these changes

@choldgraf choldgraf choldgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdpetrou @choldgraf @MSeal