feat: implement Output widget that mimics a frontend #68
Conversation
|
Fixes #24 I've added a changelog entry and bumped the version number. It's a new workflow I'm using, which makes it easier to track changes (and keep semantic versioning). |
maartenbreddels
force-pushed
the
feat_mimic_output_widget
branch
2 times, most recently
from
8a994e8
to
6f2cee2
Compare
|
Failure at https://travis-ci.org/github/jupyter/nbclient/jobs/691227550 seems unrelated, but a bit worrying. |
|
This test fails randomly, I know it's a problem. I'm restarting it. |
|
Now it passes 😄 |
nbclient/client.py
Outdated
| data = content['data'] | ||
| state = data['state'] | ||
| comm_id = msg['content']['comm_id'] | ||
| if state['_model_module'] == '@jupyter-widgets/output' and\ |
There was a problem hiding this comment.
Same here, probably filter by target name.
maartenbreddels
force-pushed
the
feat_mimic_output_widget
branch
2 times, most recently
from
13a91d1
to
af7959b
Compare
|
docs fail because of missing ipykernel dependency: Not sure how to handle this, we probably don't want or need to depend on it right? It is only needed for |
|
I think @choldgraf should be able to help us here. |
nbclient/output_widget.py
Outdated
| @@ -0,0 +1,85 @@ | |||
| from ipykernel.jsonutil import json_clean | |||
There was a problem hiding this comment.
Indeed, this seems like a weak reason to depend on ipykernel.
Should we duplicate the implementation of json_clean in this package instead?
There was a problem hiding this comment.
There is a jsonutils in jupyter_client as well but without that function.
How about adding a jsonutils here?
maartenbreddels
force-pushed
the
feat_mimic_output_widget
branch
from
af7959b
to
6add32d
Compare
|
I added and blackified the jsontil.py, we may want to find a better long term solution some day. |
|
Yes! Really happy to see things go through. |
|
@choldgraf would you be fine with releasing 0.4.0 now? |
| # unanmbiguous binary data is base64-encoded | ||
| # (this probably should have happened upstream) | ||
| return b2a_base64(obj).decode('ascii') | ||
| else: |
Yes that did seem like overkill, but if it's coming from a working solution we can use what works until someone refactors later.
Let's double check what's still open in issues / PRs first. I added you as a maintainer on PyPI @SylvainCorlay |
|
this is super exciting :-) thanks @maartenbreddels and @SylvainCorlay for pushing this through! |
|
I am +1 on pushing out a new release unless there's an obvious blocker in our issues or a super low-hanging fruit |
|
I think #64 and maybe #58 could be addressed before a release. We're still in sub 1.0 releases so it's also ok for us to ship now and prep a 0.5 for those other two. On that note we should set a goal for 1.0 release -- it's probably pretty close? I'll start an issue to track what we want to target to be considered feature complete |
This is a port of voila-dashboards/voila#91 and subsequent fixes.