Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MermaidJS 10.3.1, accessibility features, handle MIME #2034

Merged
merged 6 commits into from
Aug 27, 2023
Merged

MermaidJS 10.3.1, accessibility features, handle MIME #2034

merged 6 commits into from
Aug 27, 2023

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Aug 23, 2023 •
edited
Loading

References

Changes

  • sync changes from jupyterlab 4.1.0a1 upstream
  • update default mermaid URL to 10.3.1
    • no public API change, so existing cached versions will be fine
      • some rendering fixes
  • hoist accessibility features
    • accTitle to the alt tag
    • accDescr to a screen reader caption element
  • add mime handling for de facto text/vnd.mermaid
    • would be lower priority than img/svg+xml, if saved by clients

@bollwyvl bollwyvl marked this pull request as ready for review August 23, 2023 15:46
@bollwyvl bollwyvl changed the title [wip] Mermaid 10.3.1, accessibility features, handle mime MermaidJS 10.3.1, accessibility features, handle mime Aug 23, 2023
@bollwyvl bollwyvl changed the title MermaidJS 10.3.1, accessibility features, handle mime MermaidJS 10.3.1, accessibility features, handle MIME Aug 23, 2023
blink1073
blink1073 approved these changes Aug 27, 2023
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@blink1073 blink1073 merged commit 9e8d252 into jupyter:main Aug 27, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve accessibility of rendered Mermaid diagrams
2 participants
@bollwyvl @blink1073