Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Prevent error from all whitespace lang string #2036

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Fix: Prevent error from all whitespace lang string #2036

merged 1 commit into from
Aug 27, 2023

Conversation

Adamtaranto
Copy link
Contributor

Add a check to make sure lang string is not an empty list after stripping out whitespace characters. Prevents error when user has a space after code block docstring but no language name.

Fixes jupyter/nbgrader#1689

Add a check to make sure lang string is not an empty list after stripping out whitespace characters. Prevents error when user has a space after code block docstring but no language name.
@Adamtaranto
Copy link
Contributor Author

Can someone please add a bug label to this?

@krassowski krassowski added the bug label Aug 27, 2023
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll cut a release with this fix tomorrow.

@blink1073 blink1073 merged commit fad2fdf into jupyter:main Aug 27, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nbconvert markdown_mistune.py breaks Manual grading view
3 participants