Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Python version support in docs #2037

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Aug 28, 2023

got out of date

not sure how best to ensure this stays in sync, since it needs to change every year. Maybe a comment where these restrictions are to note that install.rst needs updating when versions change?

got out of date

not sure how to ensure this stays in sync
@minrk minrk added the docs label Aug 28, 2023
@blink1073
Copy link
Contributor

Or we could remove this part of the docs altogether and rely on tooling like pip and PyPI:

image

@bollwyvl
Copy link
Contributor

Perhaps this could be dogfooded by porting install.rst to install.ipynb, and generating this (and probably other lines) from an appropriate source of truth, e.g. pyproject.toml or the python-version factor in the CI matrix.

Copy link
Member

@ivanov ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, we can do other dog fooding stuff, but this is a step forward from the outdated information we had before.

But I think we should keep this information in the docs, because that's what packagers will bundle and make available to users in Linux distributions, for example. People don't always have access to the internet when they have access to these docs.

@ivanov ivanov enabled auto-merge (squash) November 17, 2023 02:11
@ivanov ivanov merged commit f370e37 into jupyter:main Nov 17, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants