Merge pull request #4672 from JohanMabille/control

Added control channel to ZMQChannelsHandler
jupyter · Jul 8, 2019 · 10318a9 · 10318a9
2 parents 7223fdf + 9330418
commit 10318a9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/notebook/services/kernels/handlers.py b/notebook/services/kernels/handlers.py
@@ -22,7 +22,6 @@
 from ...base.handlers import APIHandler
 from ...base.zmqhandlers import AuthenticatedZMQStreamHandler, deserialize_binary_message
 
-
 class MainKernelHandler(APIHandler):
 
     @web.authenticated
@@ -124,7 +123,7 @@ def __repr__(self):
     def create_stream(self):
         km = self.kernel_manager
         identity = self.session.bsession
-        for channel in ('shell', 'iopub', 'stdin'):
+        for channel in ('shell', 'control', 'iopub', 'stdin'):
             meth = getattr(km, 'connect_' + channel)
             self.channels[channel] = stream = meth(self.kernel_id, identity=identity)
             stream.channel = channel

diff --git a/setup.py b/setup.py
@@ -105,7 +105,7 @@
         'ipython_genutils',
         'traitlets>=4.2.1',
         'jupyter_core>=4.4.0',
-        'jupyter_client>=5.2.0',
+        'jupyter_client>=5.3.0',
         'nbformat',
         'nbconvert',
         'ipykernel', # bless IPython kernel for now