Nudge kernel with kernel info requests until IOPub responds

jupyter · Dec 11, 2020 · 4fe3430 · 4fe3430
1 parent 4342e49
commit 4fe3430
Showing 1 changed file with 17 additions and 12 deletions.
diff --git a/notebook/services/kernels/handlers.py b/notebook/services/kernels/handlers.py
@@ -144,24 +144,26 @@ def finish():
             shell_channel.stop_on_recv()
 
         def on_shell_reply(msg):
-            self.log.debug("Nudge: shell info reply received: %s", self.kernel_id)
             if not info_future.done():
+                self.log.debug("Nudge: shell info reply received: %s", self.kernel_id)
+                shell_channel.stop_on_recv()
                 self.log.debug("Nudge: resolving shell future")
                 info_future.set_result(msg)
-            if iopub_future.done():
-                finish()
-                self.log.debug("Setting results")
-                future.set_result(info_future.result())
+                if iopub_future.done():
+                    finish()
+                    self.log.debug("Nudge: resolving main future in shell handler")
+                    future.set_result(info_future.result())
 
         def on_iopub(msg):
-            self.log.debug("Nudge: First IOPub received: %s", self.kernel_id)
             if not iopub_future.done():
+                self.log.debug("Nudge: first IOPub received: %s", self.kernel_id)
+                iopub_channel.stop_on_recv()
                 self.log.debug("Nudge: resolving iopub future")
                 iopub_future.set_result(None)
-            if info_future.done():
-                finish()
-                self.log.debug("Setting results")
-                future.set_result(info_future.result())
+                if info_future.done():
+                    finish()
+                    self.log.debug("Nudge: resolving main future in iopub handler")
+                    future.set_result(info_future.result())
 
         def on_timeout():
             self.log.warning("Nudge: Timeout waiting for kernel_info_reply: %s", self.kernel_id)
@@ -346,8 +348,11 @@ def open(self, kernel_id):
         km.add_restart_callback(self.kernel_id, self.on_kernel_restarted)
         km.add_restart_callback(self.kernel_id, self.on_restart_failed, 'dead')
 
-        for channel, stream in self.channels.items():
-            stream.on_recv_stream(self._on_zmq_reply)
+        def subscribe(value):
+            for channel, stream in self.channels.items():
+                stream.on_recv_stream(self._on_zmq_reply)
+
+        connected.add_done_callback(subscribe)
 
         return connected