prevent mutation on vdom elements

jupyter · Sep 26, 2017 · b3974b9 · b3974b9
1 parent bdd0966
commit b3974b9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/notebook/static/notebook/js/object-to-preact.js b/notebook/static/notebook/js/object-to-preact.js
@@ -93,8 +93,16 @@ define(function() {
       } else if (typeof item === "string") {
         result.push(item);
       } else if (typeof item === "object") {
-        const keyedItem = item;
-        item.key = i;
+        const keyedItem = {
+          tagName: item.tagName,
+          attributes: item.attributes,
+          children: item.children
+        };
+        if (item.attributes && item.attributes.key) {
+          keyedItem.key = item.attributes.key;
+        } else {
+          keyedItem.key = i;
+        }
         result.push(objectToPreactElement(keyedItem));
       } else {
         console.warn("invalid vdom data passed", item);

diff --git a/notebook/static/notebook/js/outputarea.js b/notebook/static/notebook/js/outputarea.js
@@ -3,7 +3,6 @@
 
 define([
     'jquery',
-    'underscore',
     'base/js/utils',
     'base/js/i18n',
     'base/js/security',
@@ -12,7 +11,7 @@ define([
     'notebook/js/mathjaxutils',
     'notebook/js/object-to-preact',
     'components/marked/lib/marked',
-], function($, _, utils, i18n, security, keyboard, configmod, mathjaxutils, otp, marked) {
+], function($, utils, i18n, security, keyboard, configmod, mathjaxutils, otp, marked) {
     "use strict";
 
     /**
@@ -711,7 +710,7 @@ define([
         );
 
         element.append(toinsert);
-        preact.render(otp.objectToPreactElement(_.clone(vdom)), toinsert[0]);
+        preact.render(otp.objectToPreactElement(vdom), toinsert[0]);
 
         return toinsert;
      };