Migrate Move multiselection test to selenium (#5158)

* converted move multiselection to selenium test * deleted the time library * Remove move_multiselection Co-authored-by: Diego Schurch <[email protected]>
jupyter · May 21, 2020 · f42f240 · f42f240
1 parent 4b9e9a4
commit f42f240
Show file tree

Hide file tree

Showing 3 changed files with 48 additions and 66 deletions.
diff --git a/notebook/tests/notebook/move_multiselection.js b/notebook/tests/notebook/move_multiselection.js
diff --git a/notebook/tests/selenium/test_move_multiselection.py b/notebook/tests/selenium/test_move_multiselection.py
@@ -0,0 +1,47 @@
+INITIAL_CELLS = ['1', '2', '3', '4', '5', '6']
+def test_move_multiselection(prefill_notebook):
+    notebook = prefill_notebook(INITIAL_CELLS)
+    def assert_oder(pre_message, expected_state):
+        for i in range(len(expected_state)):
+            assert expected_state[i] == notebook.get_cell_contents(i), f"{pre_message}: Verify that cell {i} has for content: {expected_state[i]} found: {notebook.get_cell_contents(i)}"
+
+    # Select 3 first cells
+    notebook.select_cell_range(0, 2)
+    notebook.browser.execute_script(
+        "Jupyter.notebook.move_selection_up();"   
+    )
+    # Should not move up at top
+    assert_oder('move up at top', ['1', '2', '3', '4', '5','6'])
+
+    # We do not need to reselect, move/up down should keep the selection.
+    notebook.browser.execute_script(
+        "Jupyter.notebook.move_selection_down();"
+    )
+    notebook.browser.execute_script(
+        "Jupyter.notebook.move_selection_down();"
+    )
+    notebook.browser.execute_script(
+        "Jupyter.notebook.move_selection_down();"
+    )
+
+    # 3 times down should move the 3 selected cells to the bottom
+    assert_oder("move down to bottom", ['4', '5', '6', '1', '2', '3'])
+    notebook.browser.execute_script(
+        "Jupyter.notebook.move_selection_down();"
+    )
+
+    # They can't go any futher
+    assert_oder("move down to bottom", ['4', '5', '6', '1', '2', '3'])
+
+    notebook.browser.execute_script(
+        "Jupyter.notebook.move_selection_up();"   
+    )
+    notebook.browser.execute_script(
+        "Jupyter.notebook.move_selection_up();"   
+    )
+    notebook.browser.execute_script(
+        "Jupyter.notebook.move_selection_up();"   
+    )
+
+    # Bring them back on top
+    assert_oder('move up at top', ['1', '2', '3', '4', '5','6'])
diff --git a/notebook/tests/selenium/test_multiselect_toggle.py b/notebook/tests/selenium/test_multiselect_toggle.py
@@ -1,8 +1,7 @@
-INITIAL_CELLS = ['print("a")', 'print("b")', 'print("c")']
 
+INITIAL_CELLS = ['print("a")', 'print("b")', 'print("c")']
 def test_multiselect_toggle(prefill_notebook):
     notebook = prefill_notebook(INITIAL_CELLS)
-
     def extend_selection_by(delta):
         notebook.browser.execute_script(
             "Jupyter.notebook.extend_selection_by(arguments[0]);", delta)