Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong size for some interface buttons in the tree view with Firefox #3044

Closed
ffranchina opened this issue Nov 15, 2017 · 3 comments
Closed

Wrong size for some interface buttons in the tree view with Firefox #3044

ffranchina opened this issue Nov 15, 2017 · 3 comments
Labels
status:resolved-locked
Milestone
5.3

Comments

@ffranchina
Copy link
Contributor

screen

Using Firefox, there are a lot of small sizing problem across the whole UI.
The ones highlighted in the screenshot above are the among the most annoying since they appear often in the daily usage.

I'll send a pull request later on to fix them :)
@takluyver
Copy link
Member

I also notice this, so I'm looking forward to your PR :-)

@takluyver takluyver added this to the 5.3 milestone Nov 17, 2017
ffranchina added a commit to ffranchina/notebook that referenced this issue Nov 18, 2017
@ffranchina
Solves part of the jupyter#3044 - upload button
7c32c3d
ffranchina added a commit to ffranchina/notebook that referenced this issue Nov 18, 2017
@ffranchina
Fixes completely jupyter#3044 - select all
02e1284
@ffranchina
Copy link
Contributor Author

ffranchina commented Nov 18, 2017 •
edited
Loading

I was busier than I expected but finally I made it: #3058 PR :)

I hope give more contribution in the future!

Thank you

takluyver added a commit that referenced this issue Nov 19, 2017
@takluyver
Merge pull request #3058 from ferdas/master
6f23f45 
Fixes some UI bugs in Firefox #3044
@ffranchina
Copy link
Contributor Author

Thanks :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status:resolved-locked
Projects
None yet
Milestone
5.3
Development

No branches or pull requests
2 participants
@takluyver @ffranchina