Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder Name does not change HTML title until refresh of folder's page (in 5.3) #3277

Closed
msheffey opened this issue Jan 29, 2018 · 1 comment · Fixed by #3282
Closed

Folder Name does not change HTML title until refresh of folder's page (in 5.3) #3277

msheffey opened this issue Jan 29, 2018 · 1 comment · Fixed by #3282

Comments

@msheffey
Copy link

HTML title is only updated to be the folder name when the page is refreshed, not when originally navigating to the folder's page.

After clicking on a folder:
image

Then, refreshing that page:
image

@takluyver
Copy link
Member

Thanks! The code for that is here:

NotebookList.prototype.update_location = function (path) {
this.notebook_path = path;
$('body').attr('data-notebook-path', path);
// Update the file tree list without reloading the page
this.load_list();
};

@takluyver takluyver added this to the 5.5 milestone Feb 2, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants