Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clicking with modifiers, page title updates #3282

Merged
merged 2 commits into from
Feb 2, 2018
Merged

Fix clicking with modifiers, page title updates #3282

merged 2 commits into from
Feb 2, 2018

Conversation

parente
Copy link
Member

@parente parente commented Jan 31, 2018 •
edited
Loading

  • Allow the default browser behavior when the user is holding any modifier key while clicking on a folder or breadcrumb in the fileview.
  • Update the page title when navigating via the History API

Fixes #3276, fixes #3277

@parente
Fix modified clicking of dirs, crumbs
611762b 
All the default browser behavior when the user is holding any modifier
key while clicking on a folder or breadcrumb in the fileview.
@parente
Update page / tab title when navigating
386b3a2
@parente parente changed the title Fix modified clicking of dirs, crumbs Fix modified clicking of directories, crumbs Jan 31, 2018
@parente parente changed the title Fix modified clicking of directories, crumbs Fix clicking with modifiers, page title updates Jan 31, 2018
@takluyver takluyver added this to the 5.5 milestone Feb 2, 2018
@takluyver takluyver merged commit 6d7fd5c into jupyter:master Feb 2, 2018
@takluyver
Copy link
Member

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
status:resolved-locked
Projects
None yet
Milestone
5.5
2 participants
@parente @takluyver