Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for python 3.6, add support for 3.10 #6256

Open
kevin-bates opened this issue Dec 24, 2021 · 4 comments
Open

Drop support for python 3.6, add support for 3.10 #6256

kevin-bates opened this issue Dec 24, 2021 · 4 comments
Milestone
6.5

Comments

@kevin-bates
Copy link
Member

Since Python 3.6 is end-of-life and PR #6215 drops 3.6 from the CI matrices (while adding 3.10) we should do the same at an official compacity (updating the classifiers, etc.).

I'm assuming this is something that can be delivered within a minor release and have added a 6.5 milestone.
@kevin-bates kevin-bates added this to the 6.5 milestone Dec 24, 2021
penguinolog added a commit to penguinolog/notebook that referenced this issue Dec 25, 2021
@penguinolog
Fix jupyter#6256 : migrate to python 3.7+
e497b9c 
* Update classifiers
* Update python_requires
* Fix deprecated code (some from python 2.x):
  - `io.open` -> `open`
  - `IOError` -> `OSError`  (in python 3 `IOError` is alias)
  - `socket.error` -> `OSError`
  - `u''` -> `''`
  - `str().format` -> f-strings
    (where it was quick automatically validated change)
  - `object` is not needed as base class
  - use `set` comprehensions
  - `sum` over generators (do not produce temporary lists)
  - use plain `super()`
* remove unused imports
@JasonWeill
Copy link
Collaborator

@penguinolog Is your commit tested and known to fix this issue? If so, can you please create a pull request?

@penguinolog
Copy link
Contributor

@penguinolog Is your commit tested and known to fix this issue? If so, can you please create a pull request?

PR is open and waiting for merge

@JasonWeill
Copy link
Collaborator

Tagging PR #6260 (appears to be blocked by #6213)

@penguinolog
Copy link
Contributor

Tagging PR #6260 (appears to be blocked by #6213)

Formally not blocked - 1 python file intersection. But we miss CI for frontend part (stable fail looks not good)

@JasonWeill JasonWeill mentioned this issue Feb 24, 2022
Closed
blink1073 pushed a commit that referenced this issue Apr 11, 2022
@penguinolog
Fix #6256 : migrate to python 3.7+ (#6260)
4ba07e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.5
Development

No branches or pull requests
3 participants
@penguinolog @kevin-bates @JasonWeill