Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail to open JupyterLab from Notebook v7 on main #6372

Closed
jtpio opened this issue Apr 25, 2022 · 2 comments · Fixed by #6379
Closed

Fail to open JupyterLab from Notebook v7 on main #6372

jtpio opened this issue Apr 25, 2022 · 2 comments · Fixed by #6379
Labels
bug
Milestone
7.0

Comments

@jtpio
Copy link
Member

jtpio commented Apr 25, 2022

Describe the bug

It looks like it's not possible to open JupyterLab from Notebook v7, using the latest main.

To Reproduce
Steps to reproduce the behavior:

  1. Open https://mybinder.org/v2/gh/jupyter/notebook/main?urlpath=tree
  2. Click on View > Open JupyterLab
fail-open-lab.mp4

Expected behavior

JupyterLab should open just like before.
@jtpio jtpio added the bug label Apr 25, 2022
@jtpio jtpio added this to the 7.0 milestone Apr 25, 2022
@jtpio jtpio mentioned this issue Apr 25, 2022
Closed
@jtpio
Copy link
Member Author

jtpio commented Apr 25, 2022

We should add a new UI test to make sure JupyterLab can be opened, and the web page displayed correctly.

Similar to the smoke test in https://github.com/jupyter/notebook/blob/main/ui-tests/test/smoke.spec.ts

@jtpio
Copy link
Member Author

jtpio commented Apr 25, 2022

cc @bollwyvl this seems to have been introduced in #6366

@jtpio jtpio mentioned this issue Apr 26, 2022
Merged
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
7.0
Development

Successfully merging a pull request may close this issue.

Fix opening JupyterLab from Notebook jtpio/notebook
1 participant
@jtpio