Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix opening JupyterLab from Notebook #6379

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Fix opening JupyterLab from Notebook #6379

merged 2 commits into from
Apr 27, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 26, 2022 •
edited
Loading

This should fix #6372

  • Return new page config data to avoid modifying the one used in JupyterLab
  • Add UI test to check we can open in JupyterLab

@jtpio jtpio added this to the 7.0 milestone Apr 26, 2022
@jtpio jtpio added the bug label Apr 26, 2022
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/page-config

@jtpio jtpio marked this pull request as ready for review April 26, 2022 17:59
@jtpio jtpio changed the title Do not mutate existing page config Fix opening JupyterLab from Notebook Apr 26, 2022
@jtpio jtpio merged commit 4076882 into jupyter:main Apr 27, 2022
@jtpio jtpio deleted the page-config branch April 27, 2022 06:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

Fail to open JupyterLab from Notebook v7 on main
1 participant
@jtpio