Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing jupyter-notebook.desktop file in version 7 #6704

Closed
frenzymadness opened this issue Jan 25, 2023 · 1 comment · Fixed by #6705
Closed

Missing jupyter-notebook.desktop file in version 7 #6704

frenzymadness opened this issue Jan 25, 2023 · 1 comment · Fixed by #6705
Labels
bug

Comments

@frenzymadness
Copy link
Contributor

Notebook version 6 has jupyter-notebook.desktop for the integration to the GUI desktop environments. For some unknown reason, the file was deleted in 5b6ed99

The icon, notebook.svg, is still there.
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Jan 25, 2023
@jtpio
Copy link
Member

jtpio commented Jan 25, 2023

Thanks @frenzymadness for spotting this.

For some unknown reason, the file was deleted in 5b6ed99

I think it was removed by mistake when the code base switched to Notebook 7 in this huge PR: #6294

Probably we could just add it back. Would you like to open a PR? Thanks!

@RRosio RRosio removed the status:Needs Triage Applied to issues that need triage label Jan 26, 2023
@JasonWeill JasonWeill mentioned this issue Jan 26, 2023
Closed
frenzymadness added a commit to frenzymadness/notebook that referenced this issue Jan 27, 2023
@frenzymadness
Reintroduce desktop file
3e5158a 
The desktop file was inadvertently removed in: jupyter@5b6ed99

Fixes: jupyter#6704
@frenzymadness frenzymadness mentioned this issue Jan 27, 2023
Merged
jtpio pushed a commit that referenced this issue Jan 27, 2023
@frenzymadness @pre-commit-ci
Reintroduce desktop file (#6705)
229247f 
* Reintroduce desktop file

The desktop file was inadvertently removed in: 5b6ed99

Fixes: #6704

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reintroduce desktop file frenzymadness/notebook
3 participants
@jtpio @frenzymadness @RRosio