-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove keymaps that conflict with non-English keyboards #2535
Conversation
Is it just the ctrl-alt shortcuts or also the cmd-alt shortcuts that cause this problem? I would certainly be sad to lose those. |
@minrk This is only removing the Cmd-Alt-[ shortcut, not all Cmd-Alt-* |
Sorry. My question was whether it was |
I inquired about that in the issue. Let's see what people say 👍 I think we just need to avoid using shortcuts that involve |
I believe that's anything that touch [,], and The MacOS keyboard is slightly different, but same battle. Alt is a critical key. |
Ok, so this PR just comments out the 2 commands that involve |
Yep, good point. |
Fixes #2379