Protect against hypothetical future where javascript stops using surrogate pairs #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check both surrogates with strict bounds, not just the first, in case of weirdness.
…e sensibly We don't need to count surrogate pairs if js stops using them
for surrogate pairs fix
minrk
force-pushed
the
gate-surrogate-pairs
branch
from
dc0d255
to
99e4adb
Compare
|
This looks sensible to me. Do you think there's any possibility that CodeMirror could switch to using the index in code points rather than code units, even if it's not fixed at the language level? I just realised that's still not something that this code would catch, but I suspect it's unlikely. |
|
@takluyver, almost certainly not, unless some hypothetical future version of JavaScript switches its indexing behavior (ala Python 2 vs Python 3, but this seems unlikely): codemirror/codemirror5#4750 |
|
Ok, this is fine by me then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid introducing the inverse of jupyter/jupyter_client#259
and check surrogate pairs more strictly, in case of wonky unicode that shouldn't happen but is technically possible.
bumps protocol version to 5.2 for explicit unicode fix (jupyter/jupyter_client#262)
follow-up to #2509