Find available kernelspecs more efficiently #3136
Merged
+19
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's failing the test for listing kernelspecs when one is invalid, and I don't think that can easily be fixed here; I'll need to change it in jupyter_client. |
|
Reopening to test with jupyter_client 5.2, which was just released. |
|
Looks like appveyor will fail until the jupyter_client conda package makes its way through the wickets. |
blink1073
approved these changes
Dec 18, 2017
|
Reopening to test with jupyter_client 5.2, which was just released. |
minrk
reviewed
Dec 19, 2017
setup.py
Outdated
| @@ -148,7 +148,7 @@ | |||
| 'ipython_genutils', | |||
| 'traitlets>=4.2.1', | |||
| 'jupyter_core>=4.4.0', | |||
| 'jupyter_client', | |||
| 'jupyter_client>=4.2.0', | |||
There was a problem hiding this comment.
5.2, since it needed that to pass the tests? Or is the invalid-spec issue separate?
There was a problem hiding this comment.
Yeah, it probably should be 5.2.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
find_kernel_specs()followed byget_kernel_spec()has quadratic performance with the number of available kernels, because it effectively rescans for each available kernel. Hands up, I designed this, and I can't think why I did it this way.I thought this was going to require some ugly workaround, but thankfully @captainsafia was on the case two years ago, adding the
get_all_specs()method (jupyter/jupyter_client#93). So all I've done here is switch the notebook code to use it.This should improve performance loading pages for anyone with several kernels installed.
Closes gh-3135