-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slides exportation/download to the menu #3287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks. One minor quibble...
notebook/templates/notebook.html
Outdated
@@ -109,6 +109,7 @@ | |||
<li id="download_ipynb"><a href="#">{% trans %}Notebook (.ipynb){% endtrans %}</a></li> | |||
<li id="download_script"><a href="#">{% trans %}Script{% endtrans %}</a></li> | |||
<li id="download_html"><a href="#">{% trans %}HTML (.html){% endtrans %}</a></li> | |||
<li id="download_slides"><a href="#">{% trans %}Reveal.js Slides (.html){% endtrans %}</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say that 'slides' should be lower case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, will make the change.
The test failure is unrelated - a broken link in the docs. I've opened #3292 to figure out if we can be smarter about checking the links. |
Thanks! |
I've made #3293 to fix the link, and merged this one. |
Well, you pressed the merge button at the same time I was submitting my answer, funny! |
This is something missing for a long time.
JupyterLab offers it as well.
And with the upcoming change in nbconvert about catching
reveal.js
from the CDN (by default), you get an exported/downloaded html file that you can open immediately to surf the slides.