Some Javascript syntax fixes #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues spotted by Pycharm's linter.
I know we generally don't go for 'big cleanup' PRs, so I've tried to keep the scope of this quite limited - for now, I've only changed
notebook.jswith simple improvements. Linters are more useful the fewer existing issues they show up, so if we're happy with this I might do similar cleanups to other files.One common source of warnings is unused function parameters. Unlike in Python, a Javascript function can be called with more arguments than it has: the extra arguments are ignored. This is a questionable language feature, but handy for things like
some_array.map(function (elt) {...});.