Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for async kernel management #4479

Merged
merged 10 commits into from
Apr 4, 2020
Merged

Add support for async kernel management #4479

merged 10 commits into from
Apr 4, 2020

Commits on Feb 22, 2020

  1. Refactor buffering, culling and activity monitoring into classes 

    Use composition in preparation for AsyncMappingKernelManager.
    @kevin-bates
    kevin-bates committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    677ccc3 View commit details
    Browse the repository at this point in the history

  2. Add support for AsyncMappingKernelManager 

    Supports running against incompatible jupyter_client so long as the
desired kernel_manager_class is not `AsyncMappingKernelManager`.
    @kevin-bates
    kevin-bates committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    3226b07 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. Indicate that async kernel management is configured

    @kevin-bates
    kevin-bates committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    7abd4be View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2020

  1. Convert to async/await and apply touch ups

    @kevin-bates
    kevin-bates committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    8a4beb0 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2020

  1. Move duplicated methods to mixin, fix mixin order

    @kevin-bates
    kevin-bates committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    5709862 View commit details
    Browse the repository at this point in the history

  2. Update all coroutine/yield methods to async/await, share another method

    @kevin-bates
    kevin-bates committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    788bb0e View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2020

  1. Switch class hierarchy to not use mixin base 

    This commit uses the approach used in jupyter_server jupyter#191 first proposed
by David Brochart.  This reduces code duplication and alleviates redundancy
relative to configurable options.

Also, the startup message now includes the version information.

Co-authored-by: David Brochart <[email protected]>
    @kevin-bates @davidbrochart
    kevin-bates and davidbrochart committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    72d44c5 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2020

  1. Apply changes per review 

    Add comments and rename self.super to self.pinned_superclass to
clarify intent.

Add run_sync() util method to clean up shutdown_all() invocation.
    @kevin-bates
    kevin-bates committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    99b0afd View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2020

  1. Fix detection of unsupported config, prevent async on 3.5

    @kevin-bates
    kevin-bates committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    53d4d08 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. Add comments indicating when dependency check can be removed

    @kevin-bates
    kevin-bates committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    1fc9bc0 View commit details
    Browse the repository at this point in the history