Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CodeMirror dependency #5198

Merged
merged 3 commits into from
May 15, 2020
Merged

Update CodeMirror dependency #5198

merged 3 commits into from
May 15, 2020

Conversation

bzinberg
Copy link
Contributor

@bzinberg bzinberg commented Jan 30, 2020

Per codemirror/codemirror5#6128 (comment), hoping to pick up a fix to codemirror/codemirror5#6064 that got merged in recently.

Test report

CI passes, and the repro instructions in codemirror/codemirror5#6128 (comment) no longer produce an error.

bzinberg and others added 3 commits January 30, 2020 16:09
Per codemirror/codemirror5#6128 (comment), hoping to pick up a fix to codemirror/codemirror5#6064 that got merged in recently.
…dModeByExtension` instead of passing a string. (I guess older versions of CodeMirror allowed this?)
@bzinberg bzinberg marked this pull request as ready for review January 31, 2020 01:15
@lresende lresende added this to the 6.0.4 milestone Jan 31, 2020
@kevin-bates kevin-bates mentioned this pull request May 5, 2020
24 tasks
@blink1073 blink1073 modified the milestones: 6.0.4, 6.1 May 15, 2020
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blink1073
Copy link
Contributor

Thanks @bzinberg!

@blink1073 blink1073 merged commit ebd2b57 into jupyter:master May 15, 2020
@bzinberg bzinberg deleted the zeros-crash branch May 19, 2020 22:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants