Update message about minimum Tornado version #5222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
approved these changes
Feb 11, 2020
There was a problem hiding this comment.
@kinow - these changes make sense - I just had the one adjustment. Thank you for your contribution.
notebook/notebookapp.py
Outdated
| try: | ||
| version_info = tornado.version_info | ||
| except AttributeError: | ||
| raise ImportError(_("The Jupyter Notebook requires tornado >= 4.0, but you have < 1.1.0")) | ||
| raise ImportError(_("The Jupyter Notebook requires tornado >= 5.0, but you have < 1.1.0")) | ||
| if version_info < (4,0): |
There was a problem hiding this comment.
Please update the compared version.
There was a problem hiding this comment.
Oh, missed that one, thanks @kevin-bates
There was a problem hiding this comment.
Done (squashed new commit)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was reading the code just now and noticed it says it requires notebook >= 4.0, but
setup.pysays >= 5.0 I think?notebook/setup.py
Line 101 in 43df5af
Cheers
Bruno