handle allow_origin='*' in check_referer #5898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2020
kevin-bates
reviewed
Dec 9, 2020
notebook/base/handlers.py
Outdated
| @@ -380,7 +380,7 @@ def check_origin(self, origin_to_satisfy_tornado=""): | |||
|
|
|||
| # Check CORS headers | |||
| if self.allow_origin: | |||
| allow = self.allow_origin == origin | |||
| allow = self.allow_origin == "*" or self.allow_origin == origin | |||
There was a problem hiding this comment.
Is this change more for synergy with the change below? Because it seems like this code above is addressing the wildcard.
|
Hmm. In checking to make sure this issue would also be present in jupyter server, I found that |
allow_origin can be the wildcard '*' to allow any host check_referer should match check_origin
minrk
force-pushed
the
allow_origin_wildcard
branch
from
b8458eb
to
067c399
Compare
minrk
changed the title
|
@kevin-bates good catch! I updated to apply the same logic already in check_origin to check_referer |
29 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow_origin can be the wildcard '*' to allow any host
applies logic already in check_origin to check_referer