Fix skipped tests & remove deprecation warnings #6018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
reviewed
Mar 22, 2021
There was a problem hiding this comment.
Thank you @befeleme - these changes look great. I had the comment about the stop app class name so that the test subject (StopApp) is preserved.
notebook/tests/test_notebookapp.py
Outdated
| @@ -139,7 +137,7 @@ def test_notebook_password(): | |||
| assert nb.password != '' | |||
| passwd_check(nb.password, password) | |||
|
|
|||
| class TestingStopApp(notebookapp.NbserverStopApp): | |||
| class StopTestApp(notebookapp.NbserverStopApp): | |||
There was a problem hiding this comment.
Since the purpose of this is to test the "StopApp", I would suggest a rename to StopAppTest.
There was a problem hiding this comment.
Thanks for pointing this out, fixing it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I propose some changes to the tests:
yieldfeature. That is changed to recommendedpytest.mark.parametrize.\din regular expression - use recommended raw string instead.^Test*in the class name - renaming makes it work again.