Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FilesHandler not meet RFC 6713 #6287

Closed
wants to merge 9 commits into from
Closed

Fix FilesHandler not meet RFC 6713 #6287

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
479902d
Fix to add session only after kernel validation (#6251)
Vishwajeet0510 Jan 25, 2022
126ceb3
Automated Changelog Entry for 6.4.8 on master (#6280)
kevin-bates Jan 25, 2022
d713979
Publish 6.4.8
github-actions[bot] Jan 25, 2022
2662634
Bump to 6.5.0.dev0
github-actions[bot] Jan 25, 2022
ce9ad0d
Fix FilesHandler not meet RFC 6713
Feb 18, 2022
442bfca
Merge branch '6.4.x' into master
Wh1isper Mar 20, 2022
c85149d
Update namespace.js
Wh1isper Mar 20, 2022
a463a30
Update CHANGELOG.md
Wh1isper Mar 20, 2022
65f8278
Update CHANGELOG.md
Wh1isper Mar 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion notebook/files/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,14 @@ def get(self, path, include_body=True):
if name.lower().endswith('.ipynb'):
self.set_header('Content-Type', 'application/x-ipynb+json')
else:
cur_mime = mimetypes.guess_type(name)[0]
cur_mime, encoding = mimetypes.guess_type(name)
if cur_mime == 'text/plain':
self.set_header('Content-Type', 'text/plain; charset=UTF-8')
# RFC 6713
if encoding == 'gzip':
self.set_header('Content-Type', 'application/gzip')
elif encoding is not None:
self.set_header('Content-Type', 'application/octet-stream')
elif cur_mime is not None:
self.set_header('Content-Type', cur_mime)
else:
Expand Down